Admin billing accounts: always set payment_terms_id = 1 when send update #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -133,7 +134,7 @@ export const BillingAccountNewPage: FC<Props> = (props: Props) => { | |||
| name: billingAccount.name, | |||
| paymentTerms: billingAccount.paymentTerms | |||
| ? parseInt(billingAccount.paymentTerms, 10) ?? 0 | |||
| : undefined, | |||
| : EnvironmentConfig.ADMIN.DEFAULT_PAYMENT_TERMS, | |||
There was a problem hiding this comment.
Consider checking if EnvironmentConfig.ADMIN.DEFAULT_PAYMENT_TERMS is defined and valid before using it as a fallback value. This ensures that the application does not encounter unexpected behavior if the configuration is missing or incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin billing accounts: always set payment_terms_id = 1 when send update