Feature - Replace direct Project DB queries with Projects API calls #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct DB queries to Postgres with Project Service API
This is done because we call it quite immediately after project creation. This may end up, that "project-processor-es" process message about project creation and project update in the wrong order. So to make sure project creation message is processed first by "project-processor-es" we adde delay before calling project update.
As project may be updated using M2M token, `updatedBy` may have a negative value in such case.
vikasrohit
suggested changes
Dec 24, 2019
- gitignore "api.env" which should be only used locally - provide more real work example in ReadMe for PROJECTS_API - docker-compose should run the service by default - improved sample.api.env to have more real-world env variables examples
vikasrohit
approved these changes
Dec 24, 2019
|
for the records, updated the new env variables in the build config (dev env) for the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.