[$75] Discussion/comment counts are incorrect in roundtables - production

[sdgun]

Steps
Log into production forums
GO to Roundtables
Check the General category

Go inside the category and check the discussions/comments

No discussions/comments inside

Screencast.2021-02-22.mp4

[jmgasper]

@sdgun - Yeah, I think this fix was part of what I had to back out to fix the permissions issue.

[jmgasper]

Challenge https://www.topcoder.com/challenges/eef1051a-26a8-48dd-bd9a-c8f1a6d9b1c9 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

[jmgasper]

@atelomycterus - I know we have a fix for this, but can we separate out the fix for this from the performance updates please? I'd like to get this pushed separately so we can get it out quicker than the performance stuff.

[jmgasper]

Challenge https://www.topcoder.com/challenges/eef1051a-26a8-48dd-bd9a-c8f1a6d9b1c9 has been assigned to obog.

This is an automated message for ghostar via Topcoder X

[atelomycterus]

@jmgasper I've checked PROD. In general, both counts are correct. I think "wrong counts" because General had 'Discussion type' before.
Solution: change categoryID for Discussion. Use 'Move'. Please test it in DEV. Create a category (Discussion type), add discussions, change the type to 'Nested', add more data, move a discussion with comments, check counts.

PROD

Check 1

From Db
'select count() from GDN_Discussion where CategoryID=1' => 4 ("DiscussionID": 1136, 1166, 1272, 2492)
'select count() from GDN_Comment where DiscussionID in (1136, 1166, 1272, 2492)' => 5 comments

Check 2

Issues 386 + 502/504

@atelomycterus - I know we have a fix for this, but can we separate out the fix for this from the performance updates please? I'd like to get this pushed separately so we can get it out quicker than the performance

#386 is a different issue. Wrong Comment count in #386 was due to 502/504 errors. If a new comment was created, and the setCache recalculation wasn't completed, then as a result the data in the cache and in the database are different.

[atelomycterus]

@jmgasper ☝️ https://discussions.topcoder.com/discussion/1136 -> You can see these discussions: