Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$80] Profile Page: Email preferences are not reflecting in real time #2058

Closed
kiranmaroju-zz opened this issue Mar 15, 2019 · 43 comments
Closed

Comments

@kiranmaroju-zz
Copy link

Describe the bug
Email preferences are not reflecting in real time. Field statuses are reflecting only after refreshing the page

To Reproduce
Steps to reproduce the behavior:

  1. Go to Email preferences page('https://www.topcoder-dev.com/settings/preferences')
  2. Enable any preference ex: 'Design Newsletter'
  3. Check the Status message at the top(should say "Changes are saved")
  4. Verify the preference option status(step2)

Expected behavior
Preference status should be reflected in real time.

Screenshots
https://dl.dropboxusercontent.com/s/b2x908ztaid0h79/oTkC3EZaly.mp4

Desktop (please complete the following information):
Dell Vostro 2520; Windows 10 | Browser: Google Chrome 73.0.3683.75 (Official Build) (64-bit)

@ThomasKranitsas ThomasKranitsas changed the title Profile Page: Email preferences are not reflecting in real time [$40] Profile Page: Email preferences are not reflecting in real time Mar 20, 2019
@ThomasKranitsas
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30086771 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30086771 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@khushimehta03
Copy link

@ThomasKranitsas can you please assign it to me? i am nt able to assign it. anyone kindly do not take as wishing to work on it and it is with me

@ThomasKranitsas
Copy link
Collaborator

@khushimehta03 please use this link https://x.topcoder.com/api/v1/github/teams/registration/7946e40e-f01a-4ced-a1c2-081e328c7d73-1553097709824 to access our org so you can assign yourself

@khushimehta03 khushimehta03 self-assigned this Mar 20, 2019
@ThomasKranitsas
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30086771 has been updated - it has been assigned to khushimehta03.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30086771 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for thomaskranitsas via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@ThomasKranitsas PR at #2246

@r0hit-gupta
Copy link
Collaborator

r0hit-gupta commented Mar 27, 2019

Is this issue being still worked upon? The author of the PR seems to be inactive.

@PrakashDurlabhji
Copy link
Contributor

@r0hit-gupta it is being worked on.updating in few hours

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas

1.In basic info page, all 3 toggles are maintained in state under tracks array.
2.so when toggle button is changed, onchange listener is called and tracks array updated and then setState is called which rerenders and Track component reflects the change.
3. In Preferences, Same role of Track component is played by ToggleableItem, which is not reflecting change on rerender even though state values are changed.dont know why toggle from true to false is not reflecting even though checked attribute is perfecr toggled.

4.After this we click save changes ,assuming above toggle has happend, though not reflecting in UI, now green successpopup appears
5. Click on profile tab, and now click again on preferences and you can see values are updated.

@ThomasKranitsas
Copy link
Collaborator

@Gauravseta your solution is not valid. We need to see the changes in real time without having to save or refresh the page.

@r0hit-gupta
Copy link
Collaborator

@ThomasKranitsas may I take this up?

@ThomasKranitsas
Copy link
Collaborator

@r0hit-gupta since we need this to be resolved ASAP and @Gauravseta was not able to solve this, you may take it.

@Gauravseta
Copy link
Collaborator

@r0hit-gupta sorry i am already active on it

@ThomasKranitsas
Copy link
Collaborator

@Gauravseta the 24h period has passed and your solution does not work.

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas i will be able to solve it give me few minutes please. my PR is completed and working

@ThomasKranitsas
Copy link
Collaborator

Ok, you have 30 more minutes

@ThomasKranitsas
Copy link
Collaborator

after that, @r0hit-gupta will take this up

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas my PR is only solution to this problem and someone else then take my efforts.

@r0hit-gupta can you please try on this till then.
#2192

there is also one more issue open for pickup.

@ThomasKranitsas
Copy link
Collaborator

You mean this one #2280 ?

If yes, this is not working on my end.

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas done it is working updating PR

@ThomasKranitsas
Copy link
Collaborator

Make sure the tests pass

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas it is behaving weird again. I am 100% sure my PR is solution.
dont know why browser is not reflecting values on toggling.
kindly see attached screenshot which show true values but ToggleableItem component is not reflecting it. though checked value inside ToggleableItem is also true. i checked in console and everywhere.
2058

@ThomasKranitsas
Copy link
Collaborator

Well, that's what you are supposed to fix.

@r0hit-gupta
Copy link
Collaborator

@ThomasKranitsas so may I take this issue up? I may have a solution.

@Gauravseta
Copy link
Collaborator

@ThomasKranitsas i am tired now, since 3 hours debugging and also before that invested a complete day.
i still feel my PR is solution, also revised react concepts , but dont know why html and broswer reacting this way. or i am missing just 1% and 99% it is done?

i will check whoever raises PR what modifications are done apart from my solution because same code is working in Basic Info.

@r0hit-gupta u can take it and give it a try.

@ThomasKranitsas
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30086771 has been updated - it has been assigned to rohitgupta_.

This is an automated message for thomaskranitsas via Topcoder X

@Gauravseta
Copy link
Collaborator

@r0hit-gupta what a timing

@r0hit-gupta
Copy link
Collaborator

@ThomasKranitsas please review.

@ThomasKranitsas
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30086771

This is an automated message for thomaskranitsas via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants