Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Sup 1508 sup 1509 community pages #410

Merged
merged 13 commits into from
Oct 26, 2015
Merged

Conversation

ajefts
Copy link
Contributor

@ajefts ajefts commented Oct 20, 2015

@parthshah This is for 2 new pages (members and statistics). Much of it is just static links and content. Some is driven by mock son files what we’ll need to later replace with an API call, but for now as long as the site will work with the mocks I’m ok with it. We can talk about contentful or something else later.

I could use some help properly referencing URL constants in the jade templates as opposed to hardcoding them to prod URLs, which is what they are right now.

Thanks.

@parthshah
Copy link
Contributor

@ajefts Overall this looks good but I'd like to convert this into it's bower module for the following reasons -

  • Longer term I dont know if these community pages should be their own app or live within topcoder-app.
  • In either case, the rate of change on these pages would be a lot less than rest of topcoder-app and we will have less testing overhead if it's installed as an bower module.
  • there is very little or no code being re-used here.

Things we'll have to do to get it there -

  • create a separate github repo for this and wrap this in a bower module
  • inject a constants object when this module is initialized (this should take care of hard-coded values including domains
  • figure out if there any other changes we would need to make on topcoder-app to support this model.

@parthshah parthshah merged commit cd3ae1f into dev Oct 26, 2015
@parthshah parthshah deleted the sup-1508-sup-1509-community-pages branch December 9, 2015 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants