Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

[$10] - Footer margins #1041

Closed
Closed
@birdofpreyru

Description

@birdofpreyru

On the pages served by the code from this repo, margins around the footer are too large (the screenshot is from the Dashboard page for past challenges in Code track, but similar problem is with all pages):
scr-07

We should decrease the spacing (1) to a reasonable size, and replace spacing (2) by padding (i.e. it will be to have that spacing there, but it should be a part of the footer, thus dark gray). Please have a look at the current challenge listing page, we want to have the footer looking similarly to that page.

Also, please check that changing these does not break the infinite scrolling of past challenges (for the reference, here are the ticket and PR implementing that infinite scrolling: #906, #962. If you check my last comment in the ticket, at the moment the logic behind when we trigger the loading of new porting of challenges relies on a hard-coded height of the footer. Probably, you will have to tune corresponding constant after you change margins around the footer)

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions