This repository was archived by the owner on Mar 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
DEM-1207 Update Type Controller for new Data Model #24
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3d1b100
update controller for optimist
7ef63cf
update specs
6b46748
style fix
e157147
begin data refactor
652af3f
update requestType data
42b2d06
style fixes to submit work service
e7eb1e3
update specs
78bae33
Merge branch 'master' into DEM-1207
aselbie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,159 @@ | ||
| 'use strict' | ||
|
|
||
| SubmitWorkTypeController = ($scope, SubmitWorkAPIService) -> | ||
| vm = this | ||
| vm.work = | ||
| name : null | ||
| requestType: null | ||
| summary : null | ||
| features : [] | ||
|
|
||
| vm.requestTypes = | ||
| code: 'code' | ||
| design: 'design' | ||
| SubmitWorkTypeController = ($scope, $rootScope, Optimist, SubmitWorkService) -> | ||
| vm = this | ||
| vm.loading = true | ||
| vm.showSuccessModal = false | ||
| vm.workId = $scope.workId | ||
|
|
||
| isValid = -> | ||
| vm.work.name && vm.work.requestTypes.length && vm.work.summary | ||
|
|
||
| vm.save = (onSuccess) -> | ||
| if isValid() | ||
| if vm.workId | ||
| params = | ||
| id: vm.workId | ||
|
|
||
| resource = SubmitWorkAPIService.put params, vm.work | ||
|
|
||
| resource.$promise.then (response) -> | ||
| onSuccess? response | ||
|
|
||
| resource.$promise.catch (response) -> | ||
| config = | ||
| name: null | ||
|
|
||
| config.requestTypes = [ | ||
| name: 'Design' | ||
| id: '1235' | ||
| selected: false | ||
| , | ||
| name: 'Design & Development' | ||
| id: '1234' | ||
| selected: false | ||
| ] | ||
|
|
||
| config.devices = [ | ||
| name: 'iPhone5c' | ||
| id: '1234' | ||
| selected: false | ||
| , | ||
| name: 'iPhone5s' | ||
| id: '1235' | ||
| selected: false | ||
| ] | ||
|
|
||
| config.orientations = [ | ||
| name: 'Landscape' | ||
| id: '1234' | ||
| selected: false | ||
| , | ||
| name: 'Portrait' | ||
| id: '1235' | ||
| selected: false | ||
| ] | ||
|
|
||
| config.operatingSystems = [ | ||
| name: 'iOS7' | ||
| id: '1234' | ||
| selected: false | ||
| , | ||
| name: 'iOS8' | ||
| id: '1235' | ||
| selected: false | ||
| ] | ||
|
|
||
| vm.save = -> | ||
| workValid = typeValid() | ||
| updates = getUpdates() | ||
| if workValid | ||
| SubmitWorkService.save(updates).then -> | ||
| vm.showSuccessModal = true | ||
|
|
||
| typeValid = -> | ||
| updates = getUpdates() | ||
| isValid = true | ||
| for type, value of updates | ||
| if Array.isArray value | ||
| isValid = false unless value.length | ||
| else | ||
| vm.work.status = 'Submitted' | ||
| resource = SubmitWorkAPIService.post vm.work | ||
|
|
||
| resource.$promise.then (response) -> | ||
| vm.showSuccessModal = true | ||
|
|
||
| onSuccess? response | ||
|
|
||
| resource.$promise.catch (response) -> | ||
|
|
||
| onSuccess? response | ||
|
|
||
| resource.$promise.catch (response) -> | ||
|
|
||
| mockify = (work) -> | ||
| work.requestTypes = [] | ||
| work.devices = | ||
| iPhone5c: false | ||
| iPhone5s: false | ||
|
|
||
| work.orientation = | ||
| landscape: false | ||
| portrait: false | ||
|
|
||
| work.os = | ||
| iOS7: false | ||
| iOS8: false | ||
|
|
||
| isValid = value | ||
|
|
||
| isValid | ||
|
|
||
| getUpdates = -> | ||
| updates = | ||
| requestType: vm.work.requestType | ||
| name: vm.work.name | ||
| summary: vm.work.summary | ||
| devices: [] | ||
| orientations: [] | ||
| operatingSystems: [] | ||
|
|
||
| vm.type.devices.forEach (device) -> | ||
| if device.selected | ||
| updates.devices.push | ||
| id: device.id | ||
|
|
||
| vm.type.orientations.forEach (orientation) -> | ||
| if orientation.selected | ||
| updates.orientations.push | ||
| id: orientation.id | ||
|
|
||
| vm.type.operatingSystems.forEach (operatingSystem) -> | ||
| if operatingSystem.selected | ||
| updates.operatingSystems.push | ||
| id: operatingSystem.id | ||
|
|
||
| updates | ||
|
|
||
| onChange = -> | ||
| if SubmitWorkService.work | ||
| # TODO: remove mock data | ||
| SubmitWorkService.work.devices = [id:'1234'] | ||
| SubmitWorkService.work.orientations = [id:'1235'] | ||
| SubmitWorkService.work.operatingSystems = [id:'1235'] | ||
|
|
||
| vm.work = | ||
| name: SubmitWorkService.work.name | ||
| requestType: SubmitWorkService.work.requestType | ||
| summary : SubmitWorkService.work.summary | ||
| devices: SubmitWorkService.work.devices | ||
| orientations: SubmitWorkService.work.orientations | ||
| operatingSystems: SubmitWorkService.work.operatingSystems | ||
| else | ||
| vm.work = | ||
| name: null | ||
| requestType: null | ||
| summary : null | ||
| devices: [] | ||
| orientations: [] | ||
| operatingSystems: [] | ||
|
|
||
| vm.loading = false | ||
|
|
||
| unless vm.type | ||
| vm.type = config | ||
| # set already selected choices to selected on vm | ||
| vm.work.devices.forEach (device) -> | ||
| vm.type.devices.forEach (vmDevice) -> | ||
| if device.id == vmDevice.id | ||
| vmDevice.selected = true | ||
|
|
||
| vm.work.orientations.forEach (orientation) -> | ||
| vm.type.orientations.forEach (vmOrientation) -> | ||
| if orientation.id == vmOrientation.id | ||
| vmOrientation.selected = true | ||
|
|
||
| vm.work.operatingSystems.forEach (os) -> | ||
| vm.type.operatingSystems.forEach (vmOs) -> | ||
| if os.id == vmOs.id | ||
| vmOs.selected = true | ||
|
|
||
| updates = getUpdates() | ||
|
|
||
| activate = -> | ||
| if vm.workId | ||
| params = | ||
| id: vm.workId | ||
|
|
||
| resource = SubmitWorkAPIService.get params | ||
| destroyWorkListener = $rootScope.$on "SubmitWorkService.work:changed", -> | ||
| onChange() | ||
|
|
||
| resource.$promise.then (response) -> | ||
| vm.work = response | ||
| #TODO: remove once all properties are in payload | ||
| mockify vm.work | ||
| $scope.$on '$destroy', -> | ||
| destroyWorkListener() | ||
|
|
||
| resource.$promise.catch (response) -> | ||
| # TODO: add error handling | ||
|
|
||
| resource.$promise.finally -> | ||
| vm.loading = false | ||
| if vm.workId | ||
| SubmitWorkService.fetch(vm.workId) | ||
| else | ||
| vm.loading = false | ||
| onChange() | ||
|
|
||
| vm | ||
|
|
||
| activate() | ||
|
|
||
| SubmitWorkTypeController.$inject = ['$scope', 'SubmitWorkAPIService'] | ||
| SubmitWorkTypeController.$inject = ['$scope', '$rootScope', 'Optimist', 'SubmitWorkService'] | ||
|
|
||
| angular.module('appirio-tech-ng-submit-work').controller 'SubmitWorkTypeController', SubmitWorkTypeController | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets avoid using
$rootScope.$on, an alternative option is to use$scope.$watch