IE6 support, and ES5 assumptions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this one. I don't think there's any plan to have strong versioned support for IE but feel free to send more tweaks like this in the future! |
toots
added a commit
that referenced
this pull request
Jun 13, 2013
IE6 support, and ES5 assumptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if compatibility is a target of these browserify modules … but currently, IE6 bugs out with “Object doesn't support this property or method.”
This is coming, at the very least, from calls to
.isArray(), which is ES5, and not available in IE6. There's probably other ES5 / IE6 bugs, as well. I can probably clean these up for you, if backwards-compatibility is something you're willing to sign-on for and maintain? (Also, same question applies to other Browserify projects.)It will most likely require including some ES5 shims, which will add weight to everything …