jj #3
Merged
jj #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visitor always returned `null` result, and using `Node` as result type was misleading.
Default implementation provided by `DefaultTraversalVisitor` is suitable for `Void` result. Moreover, `DefaultTraversalVisitor` is useful base class for when traversing a tree (a `Void` result), not when transforming it (non-`Void` result).
The decision of how unnest expressions map to output fields is now determined by the analyzer. Doing this in the planner duplicates effort and is brittle.
This simplifies join operator as: 1. Probe is spilled in just one place. Previously probe was spilled when page was added or output was requested 2. Join operator state is now split between two internal WorkProcessors which a) join probe b) manage final unspilling 3. Operator state is not managed across multiple classic in/out operator methods
It's caller responsibility to choose when we append outer row.
Stress testing showed that Rubix caching is not stable with parallel warmup enabled. Temporarily diabling by default.
In our testing, a cloud's network proved to be not reliable. We observed data corruption when transmitting data over TCP between Presto nodes (internal communication unsecured, no compression). Verify data integrity to prevent incorrect query results. Optionally retry when data corruption is detected.
Internal Rubix configuration is modified by Rubix (BookKeeper and LocalDataTransferServer). If same cache key is used then FileSystem for such configuration can be cached by PrestoFileSystemCache causing cache to be disabled.
Co-authored-by: qqibrow <qqibrow@gmail.com> Co-authored-by: Zhenxiao Luo <luoz@uber.com>
This allows running queries over the results of a raw Elasticsearch query.
It extends the syntax of the enhanced ES table names with the following:
SELECT * FROM es.default."<index>$query:<base32-encoded ES query>"
The query is base32-encoded to avoid having to deal with escaping quotes and case
sensitivity issues in table identifiers.
The result of these query tables is a table with a single row and a single column
named "result" of type JSON.
We can directly use the stream method in any collection.
In real deployments Rubix on coordinator is not part of caching node pool. This pollutes coordinator log with Rubix error messages whenever coordinator reads a file (e.g ACID version file). This commit disables caching on coordinator by default. Caching on coordinator can still be enabled via feature toggle for development purpose.
Presto's JSON type imposes additional constraints that are not desirable for this use case: JSON values must be equatable and orderable. This requires parsing and re-organizing the document to canonicalize field ordering. Using VARCHAR will also play better with the SQL 2016 JSON features, which operate on binary or string data directly.
Additionally - remove spfileXE.ora and set paramaters programmatically - remove redundant "super." in TestingOracleServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.