Rebas #1
Merged
Rebas #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both for system-level and connector-level access control
This adds compilation and maven checks with Java 13 on CI. This also restores running maven checks on Java 8 that were removed in f5b8496. As long as we support Java 8 for development, it is better to run check on 8 too.
Hive metastore allows external location pointing at another managed table's location, so allow the same in file metastore.
Calling Regions.getCurrentRegion() attempts to access the EC2 instance metadata endpoint, but doing so repeatedly can result in being rate-limited. When that happens, null is returned and other operations that access the metadata endpoint such as instance profile credential refreshes can fail. This updates calls to Regions.getCurrentRegion() through a new class that caches the first successful region lookup and fails loudly when current region resolution fails instead of returning null.
This allows large prepared statements.
This is useful for connectors that have a source decimal value that is larger than Presto supports and thus need to round it.
This adds support for changing the owner of an existing schema to a new user or role.
`information_schema` will be inaccessible anyway. `sys` could be accessible, but - it doesn't work (contains JdbcStorageHandler tables and Hive views) - exposing it may require proper handling in access control.
Some implementations, especially of SystemAccessControl, might need to know the type of a column to produce an appropriate masking expression. For example, a typed null, by producing CAST(null AS <type>).
Before this change, cross join required that the outputSymbols list
was a concatenation of outputSymbol lists of left source and right source.
This change adds support for reordering the left-source and right-source
symbols in the operator. It is still required that left-source symbols
precede right-source symbols in the outputSymbols list.
Example: for
cross join
- left source outputs [a, b],
- right source outputs [c],
before this chenge, the only supported output layout was [a, b, c].
After this change, also [b, a, c] is supported.
This fixes the problem of conflicting JMX keys for S3 statistics when Hive and Iceberg connectors are loaded.
This is required to use access control during expression analysis. Access control requires to SecurityContext which requires a transaction.
This fixes TestAccumuloDistributedQueries failure.
- Remove redundant variable usage - Prefer assertEquals if possible - Prefer assertNull if possible - Avoid raw type usage - Remove deprecated beginInsert usage
Since configuration directory (etc) is binded in read-only mode binding a completely new file in an environment extender is imposible which is why this placeholder is neeeded.
Allows for better reuse in connectors reading Parquet, such as the IcebergPageSourceProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.