This repository was archived by the owner on Oct 1, 2026. It is now read-only.
Repository navigation
Delete elapsed-time termination of agent turns and jobs (#88) - #90
Merged
Merged
Conversation
This was referenced Sep 24, 2026
…ership Finding 1: the OpenCode drive loop could poll forever when the session went idle after activity without a terminal assistant result. The non-busy branch now reuses the existing activity tracker and stall/probe/abort machinery when the turn is not terminal and not prompt-waiting, so genuine silence past the policy window ends the turn as stalled. No elapsed deadline is restored; live part/tool activity keeps the turn alive. Finding 2: core._durable_run rc 125 (supervisor lost with the CLI child still alive) fell through the Grok ownership check as an ordinary worker failure, risking a new attempt queued behind an unsupervised child. rc 125 now blocks as ownership like 124/143, with timeout language removed from the comment. Tests: faithful idle_incomplete/idle_empty fake modes plus stalled_retry assertions; Grok rc125 ownership/blocked assertions with no-duplicate-writer, unknown-process, cancel, and rc1 preservation checks.
This was referenced Sep 24, 2026
Replace the log-read race with a spawn gate and add the reviewed trigger faithfully: a real core._durable_run loses its supervisor (SIGKILL on the exact recorded supervisor pid) while the owned fake-Grok hold child stays live. The durable run returns rc 125 with the child live and owned; feeding that authentic result through controller.run_implementation blocks as ownership with exactly one worker spawn, no escalation, targeted owned-child cleanup, working explicit cancel, and unknown processes untouched. Keeps the injected rc125/rc124/rc1 classification coverage. No production change.
lukemaj
marked this pull request as ready for review
September 24, 2026 21:19
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #88.
Outcome: productive agents stay running regardless of total elapsed time. Elapsed-time killing is deleted, not increased: no per-turn or per-job deadline exists anywhere in the runner.
What changed (base 77d0010):
Correction da15150 (independent review of 77d0010, REQUEST_CHANGES, 2 findings):
Correction 3a24647 (coordinator proof-gap review of da15150):
Proof (exact candidate 3a24647):
No merge, release, or install. Independent exact-candidate re-review still required (coordinator-owned).