Repository navigation
fix(server): children start in full access; drop agent- and kit-set runtimeMode - #89
Merged
Merged
Conversation
An agent set approval-required on a background child on its own, so every approval went to the user and the child sat blocked while the parent reported it running. The child's mode now comes only from the role kit, else the parent thread. A runtimeMode passed anyway is dropped. Closes #88 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…Mode A child's approvals go to the user, never to the planner, and the planner cannot see or answer them, so any restricted mode stalls a child unseen. Copying the parent's mode was also wrong: a read-only dispatcher would make its implementers read-only. Children now always start in T3's default full-access mode, and the unused role-kit runtimeMode is removed. Saved settings that still carry it load and drop the key. Refs #88 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 1, 2026
Closed
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: child threads always start in
full-access;spawn_threadno longer takesruntimeMode, and the Prism role kit no longer has one.Why: a child's approvals go only to the user and the planner cannot see or answer them, so a restricted child stalls unseen; copying the parent's mode would also make a read-only dispatcher's implementers read-only.
So what: ready for review; merging needs the user's approval.
Closes #88
Change
threads/tools.ts: removedruntimeModefromSpawnThreadInput; theroledescription no longer promises per-role permissions.threads/handlers.ts: a child is created withDEFAULT_RUNTIME_MODEinstead ofkit ?? parent.contracts/prism.ts: removedruntimeModefrom role kits and kit patches. Saved settings carrying it still decode (the key is dropped).runtimeModeand a passed value is dropped (roles.test.ts); the child of anapproval-requiredparent starts infull-access(childReportState.test.ts); old saved settings load (prism.test.ts).Proof
vp test run src/mcp/toolkits/threads(apps/server): 41 passed.vp test run src/prism.test.ts(packages/contracts): 9 passed.tsc --noEmitapps/server and packages/contracts: exit 0.expected 'approval-required' to be 'full-access'.Elon record
spawn_thread.runtimeMode, the role-kitruntimeMode(unused in the user's settings), and parent-mode inheritance for children.handlers.tswas the only reader; no web or mobile code shows the kit field; the user's settings set no role mode; the thread toolkit has no approval tool or waiting-for-approval status.Done by Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code