Open PRs from the Issues view and chat #N links in the app's PR panel

[lukemaj]

Parent

#25 (follow-up after merge)

Outcome

Pull requests shown in the Issues view and PR references in chat open in the app's PR panel, like PRs everywhere else in Chromeria, instead of opening GitHub or doing nothing.

Problem

• The Issue side panel lists linked PRs as plain external links (apps/web/src/components/issues/IssueDetailPanel.tsx ~244, target="_blank"), so clicking opens GitHub.
• A PR referenced in chat as #134 is autolinked to https://github.com/<repo>/issues/134 (pullRequestMarkdown.logic.ts ~179). GitHub numbers Issues and PRs together, so this is really PR fix(server): preserve stored effort for agent-started turns #134; clicking it either does nothing or opens GitHub, not the in-app PR panel. Reported by the user on 2026-09-27 with agentsmd fix(server): preserve stored effort for agent-started turns #134.

Acceptance criteria

• Clicking a PR in the Issue side panel opens that PR in the in-app PR detail panel (the same one the Pull Requests list and thread panel use), on a server that supports PRs; an explicit "open on GitHub" stays available.
• A chat link to /issues/N or #N that is actually a PR opens the in-app PR panel; one that is a real Issue opens the Issues side panel; unknown or unsupported hosts fall back to the browser. No per-link GitHub call on render; resolve on click.
• Nothing ever silently does nothing: a failed resolution falls back to opening GitHub.

Non-goals

• Changing how upstream renders PR links that already open in-app.

Blocked by

None

Required proof

• Logic tests for link classification and fallback; targeted typecheck, lint, knip, fork-check; independent review of the exact head.

[lukemaj]

Handoff: PR #41 (not merged)

• Branch fix/40-pr-deep-links, head 9e6a43f0d45993ecd02d33620d808d76d37465ce, base main.
• Issue panel PR rows now open the in-app PR panel through the existing useOpenChangeRequestLink. Each row keeps a separate "Open on GitHub" button, and Cmd/Ctrl-click also opens GitHub.
• Chat /issues/N and #N links on GitHub are classified when clicked, never on render. The new resolver in useOpenIssueOrPullRequestLink first tries the existing PR preview read and opens the PR panel. If that fails, it tries the existing Issue detail query and opens the Issues side panel. If both fail, it opens the link in the browser. Links on other hosts behave as before.
• Possible cause of "does nothing": PR links inside an Issue body kept view=issues in the page URL, so the PR panel opened behind the Issues view. openPullRequestLink.ts now drops view and issue from the URL when it opens the PR page.
• Proof: new logic tests pass (8). Related suites pass (8 files, 194 tests). Web typecheck is clean. Lint shows no new findings. Fmt check, knip:check and fork-check pass (14 features).
• Not done: no check in a running client (no dev server or browser was allowed), and no independent review of the exact head yet. The Issue requires that review before merge.
• Upstream edits: ChatMarkdown.tsx and openPullRequestLink.ts are allowlisted under the new feature issues-open-links.

[lukemaj]

Handoff update: PR #41 review fixes (not merged)

Head is now f40b4421a68ba51abec937a4a343fef593a61c60. It fixes all four findings from the independent review:

1. Blocked browser tab on web (medium). On web, if the click's user activation has run out during the reads (navigator.userActivation?.isActive === false), the app now shows a toast with an "Open on GitHub" button instead of calling window.open. The decision is browserMayBlockNewTab and has tests. The "window.open returns null" check isn't possible: the web opener passes noopener, and with that window.open always returns null.
2. Back button (low). Leaving the Issues view to open a PR now adds a history entry (it used to replace the current one), so Back returns to the Issue. Other PR-page opens still replace as before.
3. Repeat clicks (low). The hook now keeps track of links that are still resolving, per URL. A second click on the same link while it is resolving waits for that same lookup instead of starting another. This covers the chat anchor and the #N fallback without further ChatMarkdown.tsx edits.
4. Docs (nit). The user guide now says the fallback opens the link normally, following the Open links in setting.

Proof: related suites pass (8 files, 196 tests, including 2 new ones). Web typecheck exits 0. Lint shows no findings and fmt check is clean on changed files. knip:check is clean. fork-check is OK (14 features).

Not done: no check in a running client. The new head has not had an independent review.

[lukemaj]

Handoff update: PR #41 toast narrowed (not merged)

Head is now 7ab79a3c8174b9f39db535ce3d977c14b0e8dadc.

• The "Open on GitHub" toast now appears only when the fallback would open a new browser tab on the web after the click's user activation has run out. It no longer appears on desktop or when Open links in sends the link to the in-app browser. Those paths open the link directly.
• browserMayBlockNewTab now also takes the link target. The hook works out that target the same way useOpenLink does: the saved setting, whether the in-app browser is available, and whether the link sits beside a thread. ChatMarkdown.tsx passes whether a thread is present, a one-line change to an allowlisted file.
• Tests cover a web tab with expired activation (toast), active activation, desktop, the in-app browser, and browsers that don't report activation.

Proof: related suites pass (8 files, 197 tests). Web typecheck exits 0. Lint shows only the 3 warnings that were already in ChatMarkdown.tsx, and fmt check is clean. knip:check is clean. fork-check is OK (14 features).

Not done: no check in a running client. This head needs a new independent review.