Allow user reselect photos from gdrive after deleting all rows from table #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- give margin between select and upload button
…upload to wikimedia commons - Change the way disabling upload button works as it doesnt prevent the user from clicking multiple time
…er clears the table with picked files - Edit the call to gapi auth loader to occur only when the oauthToken is not defined to avoid the auth loader called again
Firefox bug (with CORS)
Add spinner that displays on the upload button when user clicks to
|
Ok, thanks for the review. I'm on it |
…er clears the table with picked files - Edit the call to gapi auth loader to occur only when the oauthToken is not defined to avoid the auth loader called again
|
Hello @tonythomas01, I have done the changes as you requested. I have also added a modal to display the files that weren't uploaded and the reason for the failed upload. For example I added these photos from my google drive as shown in this image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user select photos from gdrive and later deletes all of them, he still remains on thesame step with the button "Upload to wikimedia commons" and when he clicks on it, an empty filelist is uploaded. Below is an image to show what is explained above
The following are steps taken to solve the issue above