Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NS_ENUM (+ Doc Fixes) #45

Merged
merged 3 commits into from
Jul 22, 2013
Merged

Use NS_ENUM (+ Doc Fixes) #45

merged 3 commits into from
Jul 22, 2013

Conversation

sethfri
Copy link
Contributor

@sethfri sethfri commented Jul 17, 2013

Hi Tony,

This PR does the following:

  • Replaces enum with the NS_ENUM macro for "type-checking and switch statement completeness" improvements.
  • Fixes up the README quite a bit in terms of spelling, grammar, and in two cases Markdown syntax.
  • Fixes up the capitalization and grammar in the comments of Reachability.m. They're picky fixes, but overall they make everything more readable (and we're already doing this PR anyway).

@sethfri
Copy link
Contributor Author

sethfri commented Jul 17, 2013

Also, if you could do a v3.1.1 tag after this, that would be great. CocoaPods is still using v3.1.0, which does not include the past 9 months of improvements.

tonymillion added a commit that referenced this pull request Jul 22, 2013
@tonymillion
Merge pull request #45 from sethfri/master
7ea54e9 
Use NS_ENUM (+ Doc Fixes)
@tonymillion tonymillion merged commit 7ea54e9 into tonymillion:master Jul 22, 2013
@tonymillion
Copy link
Owner

Done & tag created!

@sethfri
Copy link
Contributor Author

sethfri commented Jul 23, 2013

Thanks Tony!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethfri @tonymillion