Repository navigation
Conversation
… uses the keyless fallback (Lyellr88#170 item 5) Item 5's --expose-network bullet: the flag's only effect is the published host binding (services/docker_commands.py:126), and everything that checks it today checks argv or a 127.0.0.1-published container. Nothing reached a running container over the interface that only exposed mode opens, so the mode that accepts off-host clients was never shown to reject unauthenticated ones. The other half of the bullet, "loopback behaves as documented", turned out not to hold in Docker at all. auth.py:16 documents a keyless mode that trusts 127.0.0.1 and 401s everyone else, but the run plan always sets SERVER_HOST=0.0.0.0, and at that host api_key_bootstrap.py:53-54 generates and persists a key when none was given. MARM_API_KEY is therefore always truthy inside the image and the documented fallback is unreachable. That is the safe direction, but it is unpinned: nothing would notice if it changed. - exposed test: publishes on 0.0.0.0 and talks to the container over the host's own routable address, not 127.0.0.1, so it exercises the path the flag exists for. Unauthenticated 401, keyed 200, /health public. - no-key test: a container given no key still challenges. The two 401s are told apart by WWW-Authenticate, which only the key branch sends (auth.py:47), and the generated key is read back out of the bind mount and used. Assisted-by: Claude (Anthropic)
Owner
Author
|
Self-verification run complete; evidence linked from Lyellr88#192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutation run to prove the new tests go red on an auth regression. Not for merge.