C++ 23 #3
Open
C++ 23 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build System Improvements: - Added a proper `clean` target to the Makefile that works with both Ninja and Make build systems - The clean target intelligently detects whether to use `ninja clean` or `make clean` based on the presence of build files - Also cleans up CMake configuration files (CMakeCache.txt and CMakeFiles directory) - Added `clean` to PHONY targets to ensure it always runs Code Modernization: resource.cpp - Eliminated C++17 warning about copying in range-based for loop by using C++23 structured bindings - Replaced `std::pair<std::string, std::string>& i` with `const auto& [key, value]` for cleaner iteration over map util.cpp - Modernized iterator-based for loops with cleaner range-based for loops - Simplified TintToSDL_Rect and TintToSDL_Color functions using range-based for loops - Used post-increment operator (idx++) inline for more concise code stage.cpp - Improved iterator management in nested for loops for better readability - Added references to iterators to avoid repeated dereferencing - Improved variable naming to be more descriptive (enemy → enemy_it, bullet → bullet_it) - Added a break statement to optimize processing when an enemy is destroyed - Improved code structure with descriptive comments All changes have been tested and build successfully with the C++23 standard.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.