Use commit rather than branch in url. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branches go out of date when changes are made, commits do not.
Owner
There was a problem hiding this comment.
@shioyama good catch! Thank you. Could you please also change the variable name branch to commit?
I'll merge after that!
Owner
There was a problem hiding this comment.
@shioyama I'll merge now and take care of it since I already have a few other changes in queue :)
tonchis
added a commit
that referenced
this pull request
Feb 23, 2015
Use commit rather than branch in url.
Owner
|
@shioyama Thanks for the patch :) FYI: https://github.com/tonchis/vim-to-github/releases/tag/v1.0.1 |
Contributor
Author
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great plugin!
Just one thing, when I make github links I want them to be permanent links, and to do that we need the commit hash not the branch name. I've made a minor change to do that.