-
Notifications
You must be signed in to change notification settings - Fork 49
fix(api): apply styleguide-fixes #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -55,7 +55,7 @@ Both forms are equivalent. | |||||
| ## API key error codes | ||||||
|
|
||||||
| | Status | Error | Meaning | | ||||||
| | -----: | ------------------------ | ----------------------------------------------------------------------------------------------------------------- | | ||||||
| | `401` | `API key does not exist` | The provided key is invalid. Check for typos or generate a new key. | | ||||||
| | `403` | `Network not allowed` | The key was issued for a different network (e.g., testnet key on mainnet). Use a key matching the target network. | | ||||||
| | `429` | `Ratelimit exceeded` | Too many requests. Back off and retry, or use an API key for higher limits. | | ||||||
| |--------|--------------------------|-------------------------------------------------------------------------------------------------------------------| | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] Status column no longer right-aligned in v3 API key error tableIn the v3 authentication documentation, the separator row for the
Suggested change
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone! |
||||||
| | `401` | `API key does not exist` | The provided key is invalid. Check for typos or generate a new key. | | ||||||
| | `403` | `Network not allowed` | The key was issued for a different network (e.g., testnet key on mainnet). Use a key matching the target network. | | ||||||
| | `429` | `Ratelimit exceeded` | Too many requests. Back off and retry, or use an API key for higher limits. | | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Status column no longer right-aligned in v2 API key error table
In the v2 authentication documentation, the separator row for the
Statuscolumn has been changed from a right-aligned numeric column definition (-----:) to a plain left-aligned definition (--------). This causes the HTTP status codes in the first column to be left-aligned, which regresses from the previous, more readable numeric alignment. The style guide requires numeric columns in tables to be right-aligned for easier scanning and comparison (seehttps://github.com/ton-org/docs/blob/main/contribute/style-guide-extended.mdx?plain=1#L890-L900for the table alignment rule). The issue is introduced directly on the separator row at line 89, which is part of the PR diff.Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!