-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support and require pytest>=3.0 #1
Conversation
1 similar comment
1 similar comment
My first outside contribution, exciting! Thanks @nicoddemus 😄 As a pytest-dev-assist tool, I think we should match the versions that pytest itself supports, for bug fixes. But I couldn't find that information on the pytest site. If only there was someone I could ask... If bugs are found in pytest 2.x will we release further 2.x patch releases? |
That warrants a 🍺 then! 😄
As long as I've been a contributor we never did a patch release of a previous minor release. I think it would only happen in an extraordinary circumstance, because we don't have the branches necessary in place for that to happen. |
Cheers 🍻 ❗
In that case, let's |
😆 |
How about a new pypi release? |
Released https://pypi.python.org/pypi/pytest-ast-back-to-python/1.0.0 In the process of doing that, I noticed the tests break with the latest version of coverage. I've created #4 to cover this. |
Thanks! 😁 |
Hi @tomviner!
I used your plugin to investigate pytest-dev/pytest#2131, this PR makes the plugin work with pytest >= 3.0. I didn't try to keep compatibility with earlier versions, but let me know if you prefer that; is not that hard to keep compatibility.
Cheers,
🍻