Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and require pytest>=3.0 #1

Merged
merged 2 commits into from
Dec 17, 2016
Merged

Conversation

nicoddemus
Copy link
Contributor

Hi @tomviner!

I used your plugin to investigate pytest-dev/pytest#2131, this PR makes the plugin work with pytest >= 3.0. I didn't try to keep compatibility with earlier versions, but let me know if you prefer that; is not that hard to keep compatibility.

Cheers,
🍻

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.516% when pulling 9066ccd on nicoddemus:pytest-3 into ec32b3a on tomviner:master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage remained the same at 64.516% when pulling 9066ccd on nicoddemus:pytest-3 into ec32b3a on tomviner:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.516% when pulling b0870b3 on nicoddemus:pytest-3 into ec32b3a on tomviner:master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage remained the same at 64.516% when pulling b0870b3 on nicoddemus:pytest-3 into ec32b3a on tomviner:master.

@tomviner
Copy link
Owner

My first outside contribution, exciting! Thanks @nicoddemus 😄

As a pytest-dev-assist tool, I think we should match the versions that pytest itself supports, for bug fixes. But I couldn't find that information on the pytest site. If only there was someone I could ask...

If bugs are found in pytest 2.x will we release further 2.x patch releases?

@nicoddemus
Copy link
Contributor Author

My first outside contribution, exciting! Thanks @nicoddemus 😄

That warrants a 🍺 then! 😄

As a pytest-dev-assist tool, I think we should match the versions that pytest itself supports, for bug fixes. But I couldn't find that information on the pytest site. If only there was someone I could ask...

As long as I've been a contributor we never did a patch release of a previous minor release. I think it would only happen in an extraordinary circumstance, because we don't have the branches necessary in place for that to happen.

@tomviner
Copy link
Owner

Cheers 🍻 ❗

As long as I've been a contributor we never did a patch release of a previous minor release. I think it would only happen in an extraordinary circumstance, because we don't have the branches necessary in place for that to happen.

In that case, let's Ⓜ️ 📧 ®️ 9️⃣ 🌀 and :shipit: !

@tomviner tomviner merged commit edb9cb3 into tomviner:master Dec 17, 2016
@nicoddemus nicoddemus deleted the pytest-3 branch December 17, 2016 14:47
@nicoddemus
Copy link
Contributor Author

😆

@nicoddemus
Copy link
Contributor Author

How about a new pypi release?

@tomviner
Copy link
Owner

Released https://pypi.python.org/pypi/pytest-ast-back-to-python/1.0.0

In the process of doing that, I noticed the tests break with the latest version of coverage. I've created #4 to cover this.

@nicoddemus
Copy link
Contributor Author

Thanks! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants