Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hyper to version 1.0 #733

Merged
merged 2 commits into from
Sep 11, 2024
Merged

update hyper to version 1.0 #733

merged 2 commits into from
Sep 11, 2024

Conversation

getong
Copy link
Contributor

@getong getong commented Jul 14, 2024

No description provided.

@getong
Copy link
Contributor Author

getong commented Jul 28, 2024

@tomusdrw
All the tests pass, would you take a look at this pr?

@xoac
Copy link

xoac commented Aug 26, 2024

I am interested in this PR too! If any help is needed I am happy to help.

@getong I think with hyper 0.14 -> 1 update you should also update reqwest 0.11 (use hyper 0.14) -> 0.12 (use hyper 1)

reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

@getong
Copy link
Contributor Author

getong commented Aug 27, 2024

I am interested in this PR too! If any help is needed I am happy to help.

@getong I think with hyper 0.14 -> 1 update you should also update reqwest 0.11 (use hyper 0.14) -> 0.12 (use hyper 1)

reqwest = { version = "0.11", optional = true, default-features = false, features = ["json"] }

Done

Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tomusdrw tomusdrw merged commit 82201a6 into tomusdrw:master Sep 11, 2024
6 checks passed
@getong getong deleted the update-hyper branch September 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants