Add wasm support to transports::Either #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platonfloria
force-pushed
the
feature/transport-either-to-support-wasm
branch
from
5d6de98
to
c1a749b
Compare
tomusdrw
requested changes
Dec 19, 2023
platonfloria
force-pushed
the
feature/transport-either-to-support-wasm
branch
from
c1a749b
to
d330fbf
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
'the trait
web3::Transportis not implemented for `web3::transports::Either' when used in wasm.Reason:
wasm Futures do not implement Send, that is required for Transport implementation of Either.
See rustwasm/wasm-bindgen#2833
Solution:
Remove Send requirement for wasm implementation by using LocalBoxFuture.