parity_netPeers function #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
reviewed
Feb 13, 2019
| @@ -36,6 +36,11 @@ impl<T: Transport> Net<T> { | |||
| CallFuture::new(self.transport.execute("net_peerCount", vec![])) | |||
| } | |||
|
|
|||
| /// Returns list of connected nodes parity | |||
| pub fn parity_peer_list(&self) -> CallFuture<PeerType, T::Out>{ | |||
There was a problem hiding this comment.
Let's move this to parity_ namespace then
There was a problem hiding this comment.
will do! :) I think it's ParitySet? Didn't realize you gave these instructions. Asked if i had the go ahead on #198
| //! Type of node (Parity, Geth...) | ||
|
|
||
| /// specify behavior of node interacting with | ||
| pub enum NodeType { |
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| pub struct PeerProtocolsInfo { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geth returns a different structure. believe it is of type HashMap. thought this would be a simpler/better alternative atm until i have time to do some digging through geth's source. will setup a seperate func for geth. hope the naming scheme is ok.
func parity_peer_listandfunc geth_peer_list.