Imagemagick Native version fails under modern nodejs

[ajfisher]

Installing this package from npm no longer works if you're using a more recent version of nodejs (v4.x or v5.x) this is due to a current failure in NaN. There is a patch involved but it means working with a specific branch of imagemacgick-native and using that as the dependency.

See this comment here for more information. elad/node-imagemagick-native#102 (comment)

Doing a clone of metalsmith-convert, changing the install location to this branch elad/node-imagemagick-native.git#travis-4.1 and then installing locally into my project allows me to use metalsmith-convert absolutely as normal.

Happy to submit a PR if you want however wasn't certain of how to run the tests etc to package it all up properly to validate nothing else has broken as a result of the upgrade.

[tomterl]

I'll gladly accept a PR -- just change what you deem necessary, testing is done automatically.

[ajfisher]

Okay cool - will sort that out today

On Sun, Jan 17, 2016 at 11:37 PM Tom Regner notifications@github.com
wrote:

I'll gladly accept a PR -- just change what you deem necessary, testing is
done automatically.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

[tomterl]

I just added node 4.0 and 4.1 to the travis test setup -- unfortunately image-magick does not compile there, so automatic tests can't work.

You can start the tests with npm test; if it does complain about missing modules, npm install should suffice.

Update: automatic tests should work again (we'll see in a moment) but testing locally prior to a commit is nevertheless a good idea.

Update 2: Yes, the tests fail now because something todo with NaN does not compile -- all set then :) do you have to change more than the package.json imagemagick entry?

[tomterl]

Once the release version of imagemagick-native compiles clean against a node >= 4.x, the package.json should b changed again.