Skip to content

Commit

Permalink
update exceptions table header and export icon (elastic#122870)
Browse files Browse the repository at this point in the history
Addresses elastic#121758 and elastic#121759.

Updates exceptions table export icon to be "download" icon and updates exceptions table header to use native EUI page headers.
  • Loading branch information
yctercero committed Jan 17, 2022
1 parent 7f15eaa commit 8c0fbdf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const getAllExceptionListsColumns = (
namespaceType,
})}
aria-label="Export exception list"
iconType="exportAction"
iconType="download"
data-test-subj="exceptionsTableExportButton"
/>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import {
EuiProgress,
EuiSearchBarProps,
EuiSpacer,
EuiPageHeader,
EuiHorizontalRule,
} from '@elastic/eui';

import type { NamespaceType, ExceptionListFilter } from '@kbn/securitysolution-io-ts-list-types';
Expand All @@ -24,8 +26,6 @@ import { useKibana } from '../../../../../../common/lib/kibana';
import { useFormatUrl } from '../../../../../../common/components/link_to';
import { Loader } from '../../../../../../common/components/loader';

import { DetectionEngineHeaderPage } from '../../../../../components/detection_engine_header_page';

import * as i18n from './translations';
import { AllRulesUtilityBar } from '../utility_bar';
import { AllExceptionListsColumns, getAllExceptionListsColumns } from './columns';
Expand Down Expand Up @@ -341,13 +341,14 @@ export const ExceptionListsTable = React.memo(() => {

return (
<>
<DetectionEngineHeaderPage
title={i18n.ALL_EXCEPTIONS}
border
subtitle={i18n.ALL_EXCEPTIONS_DESCRIPTION}
subtitle2={timelines.getLastUpdated({ showUpdating: loading, updatedAt: lastUpdated })}
<EuiPageHeader
pageTitle={i18n.ALL_EXCEPTIONS}
description={i18n.ALL_EXCEPTIONS_DESCRIPTION}
rightSideItems={[
<p>{timelines.getLastUpdated({ showUpdating: loading, updatedAt: lastUpdated })}</p>,
]}
/>

<EuiHorizontalRule />
<div data-test-subj="allExceptionListsPanel">
{loadingTableInfo && (
<EuiProgress
Expand Down

0 comments on commit 8c0fbdf

Please sign in to comment.