Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatability for follow methods #98

Merged
merged 2 commits into from Mar 13, 2020
Merged

Add compatability for follow methods #98

merged 2 commits into from Mar 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2020

I ported the changes from Making watch work with read_namespaced_pod_log so that watch can be used on methods with the keyword arg watch or the keyword arg follow. This should fix #97 !

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #98 into master will decrease coverage by 0.15%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   93.55%   93.39%   -0.16%     
==========================================
  Files          23       23              
  Lines        1551     1560       +9     
==========================================
+ Hits         1451     1457       +6     
- Misses        100      103       +3
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch.py 91% <76.92%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b2c41...dccb198. Read the comment docs.

@tomplus
Copy link
Owner

tomplus commented Mar 13, 2020

Thanks for your contribution. Could you add some unit tests for this?

Copy link
Owner

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch doesn't support methods with "follow" parameter
2 participants