add bookmark support in watcher #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 23.38% 23.39%
=======================================
Files 749 749
Lines 104982 104991 +9
=======================================
+ Hits 24555 24564 +9
Misses 80427 80427 ☔ View full report in Codecov by Sentry. |
tomplus
approved these changes
Nov 14, 2023
|
hey! thanks for checking so fast; any ideas when you plan to make the next release? (tbh kinda waiting for that fix) |
|
No problem, I'll release it this weekend. |
tomplus
pushed a commit
that referenced
this pull request
Nov 18, 2023
Co-authored-by: Thomas Kaufmann <thomaskaufmann@siemens.com>
|
It has been released, v28.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: receiving bookmarks in watchers is not handled and raises errors while unmarshalling.
The official client just returns
type==BOOKMARKtogether with the object.Even more, they have a todo to set the watcher resource_version attribute in the future; this has been done here as well.
https://github.com/kubernetes-client/python/blob/36cfbe68a509d9b9d33395b22b6fa94d7d46c30f/kubernetes/base/watch/watch.py#L103