Don't use shlex.split on cmd-path #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was previously calling shlex.split on cmd-path in addition to cmd-args. If cmd-path had a space in it (which happens on Windows, e.g. C:\Users\<username>\AppData\Local\Google\Cloud SDK\google-cloud-sdk\bin\gcloud.cmd) then shlex.split will split that command line and the command will fail.
tomplus
approved these changes
Oct 13, 2022
tomplus
pushed a commit
that referenced
this pull request
May 1, 2023
The code was previously calling shlex.split on cmd-path in addition to cmd-args. If cmd-path had a space in it (which happens on Windows, e.g. C:\Users\<username>\AppData\Local\Google\Cloud SDK\google-cloud-sdk\bin\gcloud.cmd) then shlex.split will split that command line and the command will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was previously calling shlex.split on cmd-path in addition to cmd-args. If cmd-path had a space in it (which happens on Windows, e.g. C:\Users<username>\AppData\Local\Google\Cloud SDK\google-cloud-sdk\bin\gcloud.cmd) then shlex.split will split that command line and the command will fail.
Fixes #223