Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable heartbeat value for WsApiClient #195

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Configurable heartbeat value for WsApiClient #195

merged 1 commit into from
Apr 4, 2022

Conversation

GlassOfWhiskey
Copy link
Contributor

Thir PR adds a configurable heartbeat value to the WsApiClient constructor, which defaults to None. This prevents connection timeouts when executing long commands with no outputs on remote pods.
A unit test has also been added to check that the heartbeat argument is correctly received in the constructor.

Fixes #193

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #195 (2ec63be) into master (aa44bfa) will increase coverage by 0.01%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   27.42%   27.43%   +0.01%     
==========================================
  Files         702      702              
  Lines       93764    93779      +15     
==========================================
+ Hits        25712    25727      +15     
  Misses      68052    68052              
Impacted Files Coverage Δ
kubernetes_asyncio/stream/ws_client.py 91.52% <80.00%> (+0.45%) ⬆️
kubernetes_asyncio/stream/ws_client_test.py 95.91% <100.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa44bfa...2ec63be. Read the comment docs.

@tomplus
Copy link
Owner

tomplus commented Apr 4, 2022

Many thanks!

@tomplus tomplus merged commit 90f94e7 into tomplus:master Apr 4, 2022
@tomplus
Copy link
Owner

tomplus commented Apr 5, 2022

Released in v22.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for configurable heartbeat in WsApiClient request method
2 participants