Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Watch() raises exceptions for received errors #151

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Jul 16, 2021

Fixes #150
Fixes #134

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #151 (fe0e843) into master (8f02233) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   31.17%   31.18%           
=======================================
  Files         817      817           
  Lines       93206    93206           
=======================================
+ Hits        29055    29064    +9     
+ Misses      64151    64142    -9     
Impacted Files Coverage Δ
kubernetes_asyncio/watch/watch.py 95.04% <100.00%> (+0.10%) ⬆️
kubernetes_asyncio/watch/watch_test.py 98.50% <100.00%> (-0.03%) ⬇️
kubernetes_asyncio/client/exceptions.py 43.13% <0.00%> (+17.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f02233...fe0e843. Read the comment docs.

@tomplus tomplus merged commit 89e0e6a into master Jul 16, 2021
tomplus added a commit that referenced this pull request Jul 16, 2021
fix: Watch() raises exceptions for received errors
@tomplus tomplus deleted the feat/watch-exceptions branch September 5, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

401 Error not catch properly while watching Raise exception when watch returns an error
1 participant