Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of hierarchical flags. This allows flags to be defined at multiple levels of a hierarchy, walking up through the list until finding an explicit setting. This is useful when the resolution of the value of a flag needs to be able to be overridden at multiple levels, such as a first checking a user, then a department, then an organization, and only then falling back tot he default.
The change is backwards compatible, using the existing actor protocols and requiring an explicit, new option of
for_hierarchy:
in place offor:
.The one bit of behaviour I haven't implemented yet is handling of actor percentages. I've gone back and forth on whether they should calculate the percentage on just the first actor in the list or on the collected set of all actors supplied. In other words, should
always give the same result as
In one sense it would make sense since you might always want a given actor to see the same behaviour across your system, regardless of the situation they're using it in. On the other...maybe not? Since it doesn't really come up in our particular use case, I'd welcome any input.