feat(m4): added solution 011 distinct names #2624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleattene
requested changes
Jan 28, 2023
|
|
||
| // MAIN FUNCTION | ||
| // Read all the files from a directory and print all the unique popular names (female and male) | ||
| fs.readdir(data, (err, files) => { |
There was a problem hiding this comment.
I think it's better to give the function a more meaningful name.
Example: getUniqueNames
| ); | ||
| getNames(object.maleNames).then((names) => | ||
| console.log("Popular male names", names) | ||
| ); |
There was a problem hiding this comment.
Does the function also handle any errors?
I don't see "catch" here and in the function getNames ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.