-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
bugSomething isn't workingSomething isn't workingquestionFurther information is requestedFurther information is requested
Description
The --fix-nan-and-inf option will replace all the nan and inf values in the new value specified in --fix-nan-and-inf-value. It will also replace any values above the new value with the new value itself, effectively chopping off the top end of the histogram (
Line 49 in b49125d
| data[data > params.fix_nan_and_inf_value] = params.fix_nan_and_inf_value |
I think we should either (in order of preference):
- Get rid of this one line. Does anyone still use this feature? It was originally added by Alan during my 7-BM-B beamtime in Feb 2020.
- Add a separate option to cap the allowed values in the sinogram.
- Indicate in the help string for the
--fix-nan-and-infoption that it will cap the values in the sinogram so at least this clear when using that option.
Thoughts?
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingquestionFurther information is requestedFurther information is requested