let dbSendQuery raise error if needed; return all cols for 0-row results #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues in this PR:
(1) Data frames returned by
fetchshould be 0 x n, not 0 x 0, when having zero rows.Existing behavior:
New behavior:
This allows for seamless
rbind-ing when piecing together tables, and prevents column access errors on the returned data frame when the query results happen to have zero rows.(2)
postgresqlQuickSQLis returningNULL(with a warning) on error-ing statements.The calling code should be responsible for handling raised conditions (e.g. with a tryCatch block), otherwise scripts running non-interactively won't fail-fast.
Existing behavior (no error raised):
New behavior (error raised):