Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the data plane URL with dns zone segment #62

Closed
magodo opened this issue Aug 11, 2022 · 1 comment
Closed

Extend the data plane URL with dns zone segment #62

magodo opened this issue Aug 11, 2022 · 1 comment

Comments

@magodo
Copy link
Contributor

magodo commented Aug 11, 2022

There is a new public preview feature for storage account: https://techcommunity.microsoft.com/t5/azure-storage-blog/public-preview-create-additional-5000-azure-storage-accounts/ba-p/3465466. It introduced a new property dnsEndpointType, when it is set to AzureDnsZone, the endpoints of the sub-service are changed from the form: myAccountname.[service type].[url] to myAccountname.[dnszone].[service type].[url].

This needs a change in this SDK, mostly around: internal/endpoints/endpoints.go.

Related to hashicorp/terraform-provider-azurerm#17513
magodo added a commit to magodo/terraform-provider-azurerm that referenced this issue Aug 11, 2022
@magodo
NEED SDK SUPPORT: storage account introduce dns_endpoint_type
ec43b74 
With current state, the read on the data plane resource will block for DNS issue. This needs SDK support.

See tombuildsstuff/giovanni#62.
@magodo magodo mentioned this issue Aug 11, 2022
Merged
@tombuildsstuff
Copy link
Owner

This is supported in the new base layer, closing this in favour of #68 where this'll become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tombuildsstuff @magodo