ssl issue on Windows

[davidbannon]

This problem happens in Windows (Version 10.0.19045) as well

Originally posted by @vryy in #284

[davidbannon]

Created a new issue as this relates to Windows and #284 is Linux, different aspect of the same problem.

Yep, the logfile indicates an SSL failure, if its a old SSL on your system, to be expected. Github is quite picky. Towards the end, a credentials failure but I system that is due to earlier failure rather than credentials.

@davidbannon thanks for taking a look on this. This is the log file that I got on my system. You are mentioning that tomboy links to openssl dll, but from the dependency trace I have not seen any (see image below). It's possible that OpenSSL shipped with 10.0.19045 is quite old. Can you suggest a name of a good openssl dll, then I could just copy to the installation folder to prove this hypothesis ?

Now, my advice on the Wiki about updating your OpenSSL libraries was appallingly out of date ! I have updated it with a draft , while I am absolutely not a Windows expert, it is what I use and feel comfortable with : https://github.com/tomboy-notes/tomboy-ng/wiki/Github-Sync#i-get-a-message-about-openssl-inout-error-when-trying-to-sync

While not certain to work, will almost certainly not do any harm. You sound confident with work like this so, please test my draft and let me know the result. I may be able to do same test myself tomorrow, will depend on some factors out of my control. As an aside, are you sure your original OpenSSL was an official Windows install ?

Moving forward, it could be wise to ship tomboy-ng with its own openssl, at least on Windows, to prevent any linking issue.

Yes, vryy, I could do that but every bone in my body yells "NOOOOO". Truth is I come from Unix world and this practice of scattering security sensitive .DLL files all over your system scares the willies out of me. So, I take the coward's way out and leave it up to you ! I would much rather you updated system wide but don't want to accept responsibility for anything you use that needs the old protocols. Sorry.

Davo