fix(cache): DynamoDBCache._clear only clears the first scan page#186
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the DynamoDB cache adapter's _clear method to properly handle pagination using LastEvaluatedKey, ensuring all items are deleted from large tables. It also optimizes the scan operation by using a ProjectionExpression to retrieve only the necessary keys. A new test case was added to verify the pagination logic; however, feedback suggests enhancing the test's mock implementation to explicitly assert that the ExclusiveStartKey is correctly passed in subsequent scan calls.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 87.59% 87.61% +0.02%
==========================================
Files 57 57
Lines 2927 2932 +5
==========================================
+ Hits 2564 2569 +5
Misses 363 363 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomasvotava
added a commit
that referenced
this pull request
May 19, 2026
Addresses gemini-code-assist review on PR #186: the mock returned page 2 unconditionally, so the test passed even if _clear failed to thread LastEvaluatedKey -> ExclusiveStartKey. Now assert no cursor on the first scan and the prior page's key on subsequent scans, so the pagination logic is actually exercised. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Paginate the scan on LastEvaluatedKey/ExclusiveStartKey until exhausted (typed via ScanInputTableScanTypeDef, mirroring DynamoDBStore._iter_all_keys) so tables larger than the ~1 MB scan page are fully cleared. Closes #155 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Addresses gemini-code-assist review on PR #186: the mock returned page 2 unconditionally, so the test passed even if _clear failed to thread LastEvaluatedKey -> ExclusiveStartKey. Now assert no cursor on the first scan and the prior page's key on subsequent scans, so the pagination logic is actually exercised. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tomasvotava
force-pushed
the
fix/dynamodb-cache-clear-pagination
branch
from
7915415 to
3a6da74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155
Paginates the scan on
LastEvaluatedKey/ExclusiveStartKeyuntil exhausted (typed viaScanInputTableScanTypeDef, mirroringDynamoDBStore._iter_all_keys) so tables larger than the ~1 MB scan page are fully cleared.Tests: existing dynamodb clear contract + new monkeypatched pagination test (2 passed). All gates green.
🤖 Generated with Claude Code