Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CursorColumn, ColorColumn & LineNr term color #17

Merged
merged 1 commit into from
Oct 13, 2013

Conversation

fcharlier
Copy link
Contributor

Set background color for CursorColumn, ColorColumn & LineNr to a
different color than the default background color in terminal mode.

Set background color for CursorColumn, ColorColumn & LineNr to a
different color than the default background color in terminal mode.
@tomasr
Copy link
Owner

tomasr commented Jun 17, 2013

I'm not quite sure I understand what you are doing here... can you offer more detail?

You mention the "default background color in terminal mode", but... isn't that highly dependent on the OS, terminal emulator and even default OS theme?

@fcharlier
Copy link
Contributor Author

Hi, sorry I was not clear. When running vim in a terminal, the molokai colorscheme sets the background color (different from the default terminal color).

The background colors defined by this colorscheme for CursorColumn, ColorColumn, LineNr & default are all the same.

See the screenshot at http://loin.ploup.net/~naz/pub/2013-06-17-113835_1440x900_scrot.png : from left to right:

  • master branch in gVim: cursorcolumn, line numbers & colorcolumn stand out.
  • my branch in terminal: cursorcolumn, line numbers & colorcolumn stand out. (note the brown-ish color at the bottom is the terminal default background color)
  • master branch in terminal: cursorcolumn, line numbers & colorcolumn don't stand out. (note the brown-ish color at the bottom is the terminal default background color)

@fcharlier
Copy link
Contributor Author

Hello, any news about this pull-request ? Thanks !

tomasr added a commit that referenced this pull request Oct 13, 2013
Fix CursorColumn, ColorColumn & LineNr term color
@tomasr tomasr merged commit 8305686 into tomasr:master Oct 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants