fix(git-hook): Pass branch as bytes #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dulwich expects repo branch to be bytes, not str. This seems to be a gap in the type hinting of dulwich, as other arguments to client.clone can be passed as str. Regardless, as a workaround, we can encode branch as bytes.
|
Closes: #150 |
tomasfarias
changed the title
The | None syntax is only available starting from Python 3.10, but we still support Python 3.9 as it's supported by dbt.
|
Agh, Python 3.9 requires the |
tomasfarias
commented
Apr 28, 2025
Comment on lines
+304
to
+305
| # Default to dulwich's | ||
| return None |
There was a problem hiding this comment.
As of today, this would be b"master"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dulwich expects repo branch to be bytes, not str. This seems to be a
gap in the type hinting of dulwich, as other arguments to client.clone
can be passed as str.
Regardless, as a workaround, we can encode branch as bytes.