feat: Support for basic auth in git remotes #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #112, we are dividing the work of supporting auth for git remotes into two:
DbtSSHGitRemote
andDbtHTTPGitRemote
. This split will allow us to have separate connection types for both schemes (and get rid of a bigif
).The reason why this is being split into two is that we have a chance to deliver value just with the first part, and tackle any bugs that may be easier to solve before we dive into refactoring.