Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for archive log type "6" #235

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

GeoTime61
Copy link
Contributor

Most caches use an archive log type of "5", but some caches use an archive type of "6". Retain support for type "5" and add support for type "6".

@GeoTime61
Copy link
Contributor Author

I don't know anything about GitHub, but I did my best to create a pull request with the change and a simple test.

Following the steps in CONTRIBUTING:
"isort ." worked.
"black ." worked.
"flake8" failed - AttributeError: 'EntryPoints' object has no attribute 'get'
"pytest test" (had to add " test") failed - FAIL Required test coverage of 90% not reached. Total coverage: 89.90%

Maybe you can tell me what I did wrong or help me fix the errors.

@FriedrichFroebel FriedrichFroebel linked an issue Feb 8, 2024 that may be closed by this pull request
@FriedrichFroebel
Copy link
Collaborator

Thanks for the PR.

Running python -m pip install .[dev] before running flake8 or pytest should in theory not yield any issues and work out of the box - different versions might yield different results. The GitHub Actions CI is using the same commands without any real issues.

Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FriedrichFroebel FriedrichFroebel merged commit a919365 into tomasbedrich:master Feb 8, 2024
15 checks passed
@GeoTime61 GeoTime61 deleted the log-archive branch February 8, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive Log Type Can Be 5 or 6
3 participants