Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more fields and logs from trackable page #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nagisml
Copy link

@nagisml nagisml commented Aug 23, 2022

Additional fields for TBs like origin, releaseDate
Provide the already loaded lastTBLogs from the first loaded page (up to ten logs).

@FriedrichFroebel
Copy link
Collaborator

Thanks for the PR.

Doing some quick skimming through the code, there are some things which probably should be addressed:

  • As documented in the contribution guide, please add tests (and docs if relevant) as well.
  • Why are you re-parsing the source tree for retrieving the logs?
  • We might want to move the log parsing functionality to a dedicated method to keep the parser methods more readable (see the corresponding methods for Cache objects for an example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants