You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #30 and #31, pip install was failing because of issues with dunamai implementation.
In short: when users pip installed nii2dcm it would fail in __init__.py because dunamai was attempting to determine a version based on the assumption that the files underneath are in a Git repo. However, on a user's computer, it was unlikely they were working in a local version of the nii2dcm repo, hence dunamai would fail.
Reading more, the dunamai instructions imply here and in this issue that it is incompatible with Python sdist builds and wheels/bdist should be used.
This PR:
updates setup.py and the init.py versioning call
updates the publish GitHub Actions so that only wheels are built
@jcohen02 – I think I've fixed the dunamai issue. I've tested in a fresh venv using this TestPyPI version outside of my local nii2dcm repo folder and it worked for me. Any chance you could test locally? Can add you as PR reviewer even.
I'm going to build a nii2dcm Docker container as well, which ought to help with build testing too.
PS: I always find the TestPyPI install instruction fails, so I tend to use the following: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ nii2dcm==0.1.2-post.11
@jcohen02 – I've test this quite a bit now and fairly sure it's fixed. Going to do a release soon – if it's still broken somehow I will reinvestigate (!)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #30 and #31, pip install was failing because of issues with dunamai implementation.
In short: when users pip installed nii2dcm it would fail in
__init__.py
because dunamai was attempting to determine a version based on the assumption that the files underneath are in a Git repo. However, on a user's computer, it was unlikely they were working in a local version of the nii2dcm repo, hence dunamai would fail.Reading more, the dunamai instructions imply here and in this issue that it is incompatible with Python sdist builds and wheels/bdist should be used.
This PR: