Answer:8 Angular pure pipe #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into angular-pure-pipe
…lar-challenges into angular-pure-pipe
| }) | ||
| export class HeavyComputation implements PipeTransform { | ||
| transform(value: string, index: number): string { | ||
| return `${value} - ${index}`; |
There was a problem hiding this comment.
Just to be on the safer side - can we add a null check here? Everything else is great!
Something like:
transform(name: string | null | undefined, index: number | null | undefined): string {
if (name == null || index == null) {
return '';
}
return `${name} - ${index}`;
}
There was a problem hiding this comment.
Thanks for the review @srikarphanikumar.
|
This pull request is stale because it has been open for 15 days with no activity. |
|
This pull request is stale because it has been open for 15 days with no activity. |
|
This pull request was closed because it has been inactive for 5 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I hope you're all doing well. I’ve been working on the challenge n°8 (pure pipe), and I would greatly appreciate it if someone could take a moment to review my code.
Your feedback is invaluable, and I'm open to any suggestions or improvements.
Thank you in advance for your time and assistance!
Best regards,
Ambinintsoa