Add example app: jokes (Js.Json.t version) #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiryangJung
reviewed
Apr 26, 2022
Comment on lines
+217
to
+224
| type loaderFunction = dataFunctionArgs => Js.Promise.t<Webapi.Fetch.Response.t> | ||
|
|
||
| type actionFunction = dataFunctionArgs => Js.Promise.t<Webapi.Fetch.Response.t> | ||
|
|
||
| type catchBoundaryComponent = unit => React.element | ||
|
|
||
| type errorBoundaryComponentProps = {error: Js.Exn.t} | ||
| type errorBoundaryComponent = errorBoundaryComponentProps => React.element |
There was a problem hiding this comment.
This is the binding I want and I wonder when this PR will be reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #20
It addresses a few of the points raised there but a couple of the solutions are controversial so I'm raising it as a separate PR. In particular:
Js.Json.tJs.Json.teasierI'm keen to see if you think this is moving in the correct direction or if some of these changes are just too naughty.