Linkify non-URL-friendly branch names in PRs (refined-github#986)

tom-sherman · Jan 12, 2018 · 1a1df5c · 1a1df5c
1 parent 45877ee
commit 1a1df5c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/source/features/linkify-branch-refs.js b/source/features/linkify-branch-refs.js
@@ -16,7 +16,11 @@ export function inPR() {
 	// Find the URLs first, some elements don't have titles
 	const urls = new Map();
 	for (const el of select.all('.commit-ref[title], .base-ref[title], .head-ref[title]')) {
-		urls.set(el.textContent.trim(), '/' + el.title.replace(':', '/tree/'));
+		const [repo, branch] = el.title.split(':');
+		urls.set(
+			el.textContent.trim(),
+			`/${repo}/tree/${encodeURIComponent(branch)}`
+		);
 	}
 
 	for (const el of select.all('.commit-ref')) {