Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 7zip package #699

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Add 7zip package #699

merged 4 commits into from
Jun 15, 2023

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Jun 6, 2023

No description provided.

@Eeems Eeems added the packages Add or improve packages of the repository label Jun 6, 2023
@Eeems
Copy link
Member Author

Eeems commented Jun 6, 2023

The licensing for 7zip is interesting. I picked LGPL for the license in the package, since that's what most of the code is under. I included the license file since parts are under BSD 3-clause and the unRAR license.

@Eeems Eeems marked this pull request as ready for review June 6, 2023 21:06
@bkirwi
Copy link

bkirwi commented Jun 11, 2023

Installed from CI and tested.

reMarkable: ~/ /opt/bin/7zz/7zz t toltec-test/7zip_22.01-1_rmall.ipk 

7-Zip (z) 22.01 (armt) : Copyright (c) 1999-2022 Igor Pavlov : 2022-07-15
 32-bit arm_v:7 thumb:2 locale=C UTF8=- Threads:2

Scanning the drive for archives:
1 file, 962413 bytes (940 KiB)

Testing archive: toltec-test/7zip_22.01-1_rmall.ipk
--
Path = toltec-test/7zip_22.01-1_rmall.ipk
Type = gzip
Headers Size = 10

Everything is Ok         

Size:       972800
Compressed: 962413

I feel like that install path is not quite right... among other things it means the binary is not in PATH. Otherwise seems to be working as expected.

@Eeems
Copy link
Member Author

Eeems commented Jun 11, 2023

Thanks for the rest, I must have messed up the paths when copying/pasting from other packages.

Where did the license file end up?

@bkirwi
Copy link

bkirwi commented Jun 11, 2023

reMarkable: ~/ opkg files 7zip
Package 7zip (22.01-1) is installed on root and has the following files:
/opt/bin/7zz/7zz
/opt/usr/share/licenses/7zip/License.txt

License location seems reasonable to me!

@Eeems
Copy link
Member Author

Eeems commented Jun 11, 2023

reMarkable: ~/ opkg files 7zip
Package 7zip (22.01-1) is installed on root and has the following files:
/opt/bin/7zz/7zz
/opt/usr/share/licenses/7zip/License.txt

License location seems reasonable to me!

I need to re-familiarize myself with the install doc. I never know when it wants a path to be the filename, and when it wants it to be a folder.

Thanks for the test!

@Eeems Eeems merged commit d8889e6 into testing Jun 15, 2023
@Eeems Eeems deleted the 7zip branch June 15, 2023 02:03
Eeems added a commit that referenced this pull request Jul 26, 2023
* Add 7zip package
Eeems added a commit that referenced this pull request Jul 31, 2023
### New Packages
- `tailscale-systemd` - 0.0.0-1 (#706)
  - Necessary configuration for tailscale to work on the reMarkable
- `7zip` - 22.01-1 (#699)

### Updated Packages
- `koreader` - 2023.06-1 (#696 #705)
- `plato` - 0.9.34-1 (#669)
- `erode` `fret` `oxide` `rot` `tarnish` `decay` `corrupt` `anxiety` `liboxide` `notify-send` - 2.5-2 (#697)
  - Remove rm2fb runtime dependency for reMarkable 1 devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants