Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to throw exceptions or expose problems found as Clojure data structures #6

Closed
eigenhombre opened this issue Dec 13, 2016 · 3 comments

Comments

@eigenhombre
Copy link

My team would like to fail our builds depending on linting output, which is impossible to do without parsing the output from the linting tasks (yagni, bikeshed, etc).

It would be helpful to allow the option to raise an exception or, perhaps better yet, expose the problems found as Clojure data structures so that a wrapper task could fail drastically when problems occur.

As it is we are having to dissect and reimplement portions of the library to get the desired behavior (or parse the output as strings).

@tolitius
Copy link
Owner

The problem is some of the projects.

For example Bikeshed, does not return anything besides true or false. That is true for its internal tasks as well.

For Eastwood, it does not return actuals but rather the counters, etc..

I added the --throw-on-errors on every task. It is in 0.1.4-SNAPSHOT.
Check out the handling errors docs.

Let me know if it works for you.

@eigenhombre
Copy link
Author

Thanks! Next time I'm getting my hands dirty with this I can try it out. Seems close-able for now, but will let you close the issue. Thanks again for the quick response.

@tolitius
Copy link
Owner

tolitius commented Apr 7, 2017

closing this. feel free to reopen if you have more questions.

@tolitius tolitius closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants