Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define entry point for yagni #3

Closed
kurt-o-sys opened this issue Jul 25, 2016 · 4 comments
Closed

define entry point for yagni #3

kurt-o-sys opened this issue Jul 25, 2016 · 4 comments

Comments

@kurt-o-sys
Copy link

yagni uses :main in a leiningen project to find the entry point. This entry point is skipped in the yagni analysis. However, in using boot and boot-check, this entry point is not found by yagni and there's no way to add a :main entry to boot-check (adding a :main to the jar task-options isn't really helpful here).
This results always in:

 WARN: could not find any references to the following:

<project>/-main

or something similar.

It is possible to add the main entry point in .lein-yagni, but this is somewhat confusing as one is using boot and needs to add a file which clearly points to leiningen. It would make much more sense to be able to add the entry points inside build.boot, or in .boot-yagni or something similar.

@tolitius
Copy link
Owner

sure, the args part of all the checkers is a TO DO including yagni.

I'll add args to the yagni task, so it'd be possible to pass main entry points to with-yagni

tolitius added a commit that referenced this issue Jul 27, 2016
@tolitius
Copy link
Owner

@Qsys I added options to yagni. check out the test run.

i.e.

(check/with-yagni :options {:entry-points ["app.foo/-main"
                                           "app.bar/fun"
                                           "app.baz/another-entry-point"]})))

try it out with 0.1.3-SNAPSHOT, let me know if it works for you.

tolitius added a commit that referenced this issue Jul 29, 2016
@tolitius
Copy link
Owner

I released boot-check 0.1.3 with this feature.

feel free to reopen this in case you have any more questions.

@kurt-o-sys
Copy link
Author

Great, thanks! It works :)

Op 29 juli 2016 om 18:05 schreef Anatoly notifications@github.com:

Closed #3.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants