Conversation
honzuki
approved these changes
Aug 7, 2025
Contributor
honzuki
left a comment
honzuki
left a comment
There was a problem hiding this comment.
LGTM!
2 side notes:
- switching from the CoC / Commercial Disclosure page to the home page loses the language tag!
- it would be nice to have a button that switches between Japanese and English!
(Not directly related to this PR, but we also didn't have any other Japanese pages until now)
|
|
||
| If a participant engages in behavior that violates this Code of Conduct, TokyoRust will immediately request that the behavior cease. Depending on the circumstances, we may take appropriate action, including revoking the individual's permission to attend the event. In such cases, you must comply with the instructions of the event staff without delay. Please note that no refunds of event participation fees or other costs will be made in the case of a violation of the Code of Conduct. | ||
|
|
||
| This document is released under the Creative Commons Zero license. |
Contributor
There was a problem hiding this comment.
I'm not sure how important it's, but the English version does not contain a link to the license:
https://creativecommons.org/publicdomain/zero/1.0/deed.en
Contributor
Author
There was a problem hiding this comment.
Oh, nice catch. I'll put in a followup for that.
Contributor
Author
Thanks for noticing those. I hadn't noticed 1 but it should be a quick fix. 2 I've been lazy about doing -- about time to set it up properly. Will do that in a followup PR as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To check the changes, pull down this branch and run the following from the
static-sitefolder.